[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

[Zequan Wu via Phabricator via lldb-commits]

zequanwu updated this revision to Diff 425928.
zequanwu marked 4 inline comments as done.
zequanwu added a comment.

Update: address some inline comments.

For testing, I don't know how to create minidump in yaml format like the one in `lldb/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.yaml`. Anyone knows how? Or have other ideas for testing?

> I am wondering whether attaching some kind of flag to a particular frame (similar to how we add [opt] for optimized functions) to indicate that it may not be entirely correct could be a better option.

I'm lean towards this idea that adding a flag to the frame unwinded from stack scanning, maybe all frames after that one should have the flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124198/new/

https://reviews.llvm.org/D124198

Files:
  lldb/include/lldb/Symbol/UnwindPlan.h
  lldb/include/lldb/Target/ABI.h
  lldb/include/lldb/Target/RegisterContextUnwind.h
  lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp
  lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.h
  lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
  lldb/source/Symbol/UnwindPlan.cpp
  lldb/source/Target/RegisterContextUnwind.cpp
  lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124198.425928.patch
Type: text/x-patch
Size: 21052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220429/1bc3353a/attachment-0001.bin>