[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap<T> objects when saved to cache files.

jeffrey tan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 28 08:20:07 PDT 2022


yinghuitan added a comment.

Also, to help diagnostics this kind of issue in future, it may worth to add an extra debug mode check in in `UniqueCStringMap` to ensure they are sorted. For example, in debug mode, add a `m_isSorted` flag which is set by `UniqueCStringMap::Sort()` method. All the binary search methods should assert `m_isSorted == true`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124572/new/

https://reviews.llvm.org/D124572



More information about the lldb-commits mailing list