[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

[Dave Lee via Phabricator via lldb-commits]

kastiglione added inline comments.


================
Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:718
+  /// been told.
+  ChildrenOmissionWarningStatus m_truncation_warning;
+  /// Whether we reached the maximum child nesting depth and whether the user
----------------
shafik wrote:
> Why not use in class member initialization? It looks like they have default values. I am not sure why the rest of the values where not caught the other day when I ran clang-tidy.
I was following the convention within the file. What's the ideal change, initialize all in this change? Or initialize the two that I have edited?


================
Comment at: lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp:180
     use_dynamic = target_sp->GetPreferDynamicValue();
-  else {
+    std::tie(max_depth, max_depth_is_default) =
+        target_sp->GetMaximumDepthOfChildrenToDisplay();
----------------
shafik wrote:
> My kingdom for structured bindings.
soon, hopefully.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123954/new/

https://reviews.llvm.org/D123954