[Lldb-commits] [lldb] 03049c5 - Revert "[lldb] Pin the shared cache when iterating over its images"

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2022-04-14T16:23:56-07:00
New Revision: 03049c51251189b5aafed825095f3adcd52b3dee

URL: https://github.com/llvm/llvm-project/commit/03049c51251189b5aafed825095f3adcd52b3dee
DIFF: https://github.com/llvm/llvm-project/commit/03049c51251189b5aafed825095f3adcd52b3dee.diff

LOG: Revert "[lldb] Pin the shared cache when iterating over its images"

This reverts commit af969141fa285157044e34fb6b27963c3278241b because it
didn't have the intended performance benefit to offset the increase in
our (virtual) memory usage.

Added: 
    

Modified: 
    lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index 3de3ed2f84b79..b5912e907d8e0 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -2712,7 +2712,7 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
         if (process_shared_cache_uuid.IsValid() &&
           process_shared_cache_uuid != UUID::fromOptionalData(&cache_uuid, 16))
         return;
-      const bool pinned = dyld_shared_cache_pin_mapping(shared_cache);
+
       dyld_shared_cache_for_each_image(shared_cache, ^(dyld_image_t image) {
         uuid_t dsc_image_uuid;
         if (found_image)
@@ -2769,8 +2769,6 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
               nlist_count = nlistCount;
             });
       });
-      if (pinned)
-        dyld_shared_cache_unpin_mapping(shared_cache);
     });
     if (nlist_buffer) {
       DataExtractor dsc_local_symbols_data(nlist_buffer,