[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:243
+  /// Total amount of time spent decoding.
+  std::chrono::milliseconds m_total_decoding_time{0};
 };
----------------
jj10306 wrote:
> nit: Do you need an explicit initialization?
yes, otherwise m_total_decoding_time takes the value of now(). That's a little bit counterintuitive for me


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TaskTimer.h:58
+private:
+  std::unordered_map<std::string, std::chrono::milliseconds> m_timed_tasks;
+};
----------------
jj10306 wrote:
> 
DenseMaps can't hold strings, only const char * :( 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123357/new/

https://reviews.llvm.org/D123357