[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

Tue Apr 12 02:12:52 PDT 2022

labath added a comment.

In D123020#3442738 <https://reviews.llvm.org/D123020#3442738>, @llunak wrote:

> Based on that 'introduce' comment I expect the part that you're not aware of is that all 4 of those simple commits I pushed directly changed code that had been written by me. So I still think I was following the guidelines, and I got an explicit review for all changes where I had any uncertainty, but as I said if it's expected that I'll get explicit review even for simple changes in code I'm familiar with, I can do that.

You are correct -- I was not aware of that. It is a somewhat unusual situation, with you being not being otherwise very active, but given the overall lack of activity on the gui front, I don't think anyone (who is aware of that fact) would question your ownership of those parts. So I apologise for doing so.

OTOH, if you do have a sense of ownership of (parts of) gui, then I can complain to you about the lack of testing of that feature :P, and there is another policy about patches coming with tests. (I know this looks like a bait-and-switch, but that is what has mostly upset me about those patches -- functionally I don't see anything wrong with them).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123020/new/

https://reviews.llvm.org/D123020