[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 8 17:05:10 PDT 2022


jingham marked 6 inline comments as done.
jingham added inline comments.


================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:1012-1015
+        if (log) {
+          LLDB_LOG(log, "Resolving call for class - {0} and selector - {1}",
+                   isa_addr, sel_addr);
+        }
----------------
JDevlieghere wrote:
> The `if (log)` check is redundant. It's the purpose of the macro to expand to that that. Same below.
Old habits die hard...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123421/new/

https://reviews.llvm.org/D123421



More information about the lldb-commits mailing list