[Lldb-commits] [PATCH] D123358: [trace][intelpt] Remove code smell when printing the raw trace size

Jakob Johnson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 8 05:29:32 PDT 2022

Previous message: [Lldb-commits] [PATCH] D123358: [trace][intelpt] Remove code smell when printing the raw trace size
Next message: [Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

jj10306 added a comment.

Looks good. Any reason not to have `GetRawTraceSize()` at the `Trace` interface level instead of being specific to `TraceIntelPT`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123358/new/

https://reviews.llvm.org/D123358

Previous message: [Lldb-commits] [PATCH] D123358: [trace][intelpt] Remove code smell when printing the raw trace size
Next message: [Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the lldb-commits mailing list