[Lldb-commits] [PATCH] D123340: Applying clang-tidy modernize-use-override over LLDB

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 8 01:25:34 PDT 2022


labath added a comment.

The reason for the funny `/*override*/` thingy in the mock classes is that it is impossible (in the gmock version that we use) to add the override keyword to the methods overridden by the MOCK macros. Then, having override keywords on hand-written methods triggered `-Winconsistent-missing-override`.

Or at least it used to -- have you checked that these changes don't introduce any new compiler warnings?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123340/new/

https://reviews.llvm.org/D123340



More information about the lldb-commits mailing list