[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 5 12:30:56 PDT 2022


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good. Thanks for your patience.



================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2636-2638
+          assert(llvm::isa<WritableDataBuffer>(data_buffer_sp.get()));
+          WritableDataBuffer *data_buffer =
+              static_cast<WritableDataBuffer *>(data_buffer_sp.get());
----------------
use llvm::cast instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122856/new/

https://reviews.llvm.org/D122856



More information about the lldb-commits mailing list