[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

Mon Apr 4 06:47:59 PDT 2022

labath accepted this revision.
labath added a comment.

In D122980#3424636 <https://reviews.llvm.org/D122980#3424636>, @JDevlieghere wrote:

> I feel like this came up in the past and there was a reason an unordered map couldn't work? Maybe I'm confusing this with something else. Added Pavel as he would certainly know.

This is pretty new code, so I think you must be thinking of something else.

I don't see any reason why this would have to be a std::map. I think the code just hasn't been optimized yet.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122980/new/

https://reviews.llvm.org/D122980