[Lldb-commits] [PATCH] D122486: [lldb] Fix building for mingw after changes to sigtstp_handler
Martin Storsjö via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 25 08:55:05 PDT 2022
mstorsjo added a comment.
> Alternatively the ifdef condition could be changed from !_MSC_VER to !_WIN32 - I'm unsure whether the other ones that are hooked up in mingw builds but not in MSVC builds actually ever make a difference in mingw builds.
On second thought, maybe it'd be best to just go down this route, to reduce unnecessary differences between the MSVC and mingw builds. If the (more officially supported) MSVC build can do without these signals, the mingw build should too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122486/new/
https://reviews.llvm.org/D122486
More information about the lldb-commits
mailing list