[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

In D122041#3405821 <https://reviews.llvm.org/D122041#3405821>, @kastiglione wrote:

>> There's some CMake trickery
>
> Can you shed some more light on this? Am I understanding right: these formatters are llvm, but the test would be in lldb? It seems weird that something in llvm/ would only have tests in lldb/.

You need an LLDB in order to test the dataformatter, that's why I thought the test makes most sense there. The other natural place would be `cross-project-tests/`.

> Would it be bad to move this file into lldb, and then we can test there?

It's nice & consistent to have the LLDB data formatters next to the GDB dataformatters, but I don't very strong feelings about this.

> With llvm being a monorepo, a source checkout should have access at any path. Maybe the issue would be llvm installations and packages that don't include lldb too?

The test would need to build a debuginfo-enabled binary that links against Support (which, I now realize, does not need debug info), So maybe this is not going to be much more complicated than any unit tests we are building.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122041/new/

https://reviews.llvm.org/D122041