[Lldb-commits] [lldb] 12606d1 - Revert "Expose GetAddressingBits() in the Process API."

[Adrian Prantl via lldb-commits]

Author: Adrian Prantl
Date: 2022-03-23T15:28:34-07:00
New Revision: 12606d16bc3e1c75eefc781863b199b930137068

URL: https://github.com/llvm/llvm-project/commit/12606d16bc3e1c75eefc781863b199b930137068
DIFF: https://github.com/llvm/llvm-project/commit/12606d16bc3e1c75eefc781863b199b930137068.diff

LOG: Revert "Expose GetAddressingBits() in the Process API."

This reverts commit 7504dd5e00f514628614db8ee07514c73220e597.

In newer review feedback it was pointed out that there is a better API for this in Process::GetCodeAddressMask().

Added: 
    

Modified: 
    lldb/include/lldb/Target/Process.h
    lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Target/Process.h b/lldb/include/lldb/Target/Process.h
index 7c4302342988b..7d8fbb7797d89 100644
--- a/lldb/include/lldb/Target/Process.h
+++ b/lldb/include/lldb/Target/Process.h
@@ -699,9 +699,6 @@ class Process : public std::enable_shared_from_this<Process>,
   /// Get the system architecture for this process.
   virtual ArchSpec GetSystemArchitecture() { return {}; }
 
-  /// Return the number of bits in a vmaddr that are used by valid addresses.
-  virtual llvm::Optional<uint32_t> GetAddressingBits() { return {}; }
-
   /// Get the system runtime plug-in for this process.
   ///
   /// \return

diff  --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index 12747321a2932..2e652e11ea110 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -212,10 +212,6 @@ ArchSpec ProcessGDBRemote::GetSystemArchitecture() {
   return m_gdb_comm.GetHostArchitecture();
 }
 
-llvm::Optional<uint32_t> ProcessGDBRemote::GetAddressingBits() {
-  return m_gdb_comm.GetAddressingBits();
-}
-
 bool ProcessGDBRemote::CanDebug(lldb::TargetSP target_sp,
                                 bool plugin_specified_by_name) {
   if (plugin_specified_by_name)

diff  --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
index a227e99b35768..50cef8e499dcc 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
@@ -72,8 +72,6 @@ class ProcessGDBRemote : public Process,
 
   ArchSpec GetSystemArchitecture() override;
 
-  llvm::Optional<uint32_t> GetAddressingBits() override;
-
   // Check if a given Process
   bool CanDebug(lldb::TargetSP target_sp,
                 bool plugin_specified_by_name) override;