[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

[Zequan Wu via Phabricator via lldb-commits]

zequanwu added a comment.

> Can you say (in english) what are the properties that you are trying to check there? Maybe we can find a better way to do that...

I'm trying to check for local variables values in inline functions by printing them (see inline comment on `PdbAstBuilder::ParseBlockChildren`). Since this test only runs on x64, I think I will change the live debugging test to a cpp file.



================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1485
 
 void PdbAstBuilder::ParseBlockChildren(PdbCompilandSymId block_id) {
   CVSymbol sym = m_index.ReadSymbolRecord(block_id);
----------------
This is only called when printing variables (or expression evaluation), transitively from https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L9448 . I saw an infinite recursion on this function when working on this patch because of the missing `symbols.drop_front();`. So, I want to add a live debugging test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121967/new/

https://reviews.llvm.org/D121967