[Lldb-commits] [PATCH] D122025: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 21 15:49:29 PDT 2022
jingham added a comment.
I think it makes sense to require that the CommandResultObject's command output is UTF-8 string with no embedded '\0'-s. We wouldn't do smart things with rendering command output with nulls in it, and I don't see any reason to support such a thing.
OTOH, this seems like the wrong place to check that, since it's pretty far removed from whoever would have added the null's. If we wanted to do this right, we would sanitize when you write to the CommandResultObject.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122025/new/
https://reviews.llvm.org/D122025
More information about the lldb-commits
mailing list