[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1635
+
+    def __fetch_events__(self):
+        event = lldb.SBEvent()
----------------
This contains way too many underscores. An [[ https://dbader.org/blog/meaning-of-underscores-in-python | appropriate name]] for a private function would be `_fetch_events`.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1640
+        while not done:
+            if self.listener.WaitForEvent(1, event):
+                event_mask = event.GetType();
----------------
If you're doing an infinite loop, you might as well use a blocking call.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121977/new/

https://reviews.llvm.org/D121977