[Lldb-commits] [lldb] 74b45f9 - [lldb] Migrate ProcessGDBRemote to ReportWarning

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 17 15:13:55 PDT 2022


Author: Jonas Devlieghere
Date: 2022-03-17T15:13:48-07:00
New Revision: 74b45f91b8bf7231f76c5676c4bedc9a667012e8

URL: https://github.com/llvm/llvm-project/commit/74b45f91b8bf7231f76c5676c4bedc9a667012e8
DIFF: https://github.com/llvm/llvm-project/commit/74b45f91b8bf7231f76c5676c4bedc9a667012e8.diff

LOG: [lldb] Migrate ProcessGDBRemote to ReportWarning

Added: 
    

Modified: 
    lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index d8dc229161c6b..2e652e11ea110 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -410,13 +410,13 @@ void ProcessGDBRemote::BuildDynamicRegisterInfo(bool force) {
   }
   if (target_definition_fspec) {
     // See if we can get register definitions from a python file
-    if (ParsePythonTargetDefinition(target_definition_fspec)) {
+    if (ParsePythonTargetDefinition(target_definition_fspec))
       return;
-    } else {
-      StreamSP stream_sp = GetTarget().GetDebugger().GetAsyncOutputStream();
-      stream_sp->Printf("ERROR: target description file %s failed to parse.\n",
-                        target_definition_fspec.GetPath().c_str());
-    }
+
+    Debugger::ReportError("target description file " +
+                              target_definition_fspec.GetPath() +
+                              " failed to parse",
+                          GetTarget().GetDebugger().GetID());
   }
 
   const ArchSpec &target_arch = GetTarget().GetArchitecture();


        


More information about the lldb-commits mailing list