[Lldb-commits] [PATCH] D121711: [trace][intelpt] Rename IntelPTManager and change TraceCursor::GetTimestampCounter API to general trace counter API

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 16 11:17:02 PDT 2022


wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.

just fix these two simple comments and good to go



================
Comment at: lldb/include/lldb/Target/TraceCursor.h:188-189
+  /// \param[in] counter_type
+  ///    The counter type
   /// \return
+  ///     The value of the counter or \b llvm::None if not available.
----------------



================
Comment at: lldb/include/lldb/lldb-enumerations.h:1144
 
+// Type of counter values in a trace.
+enum TraceCounter {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121711/new/

https://reviews.llvm.org/D121711



More information about the lldb-commits mailing list