[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 15 13:59:56 PDT 2022


JDevlieghere added inline comments.


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:1309
             stack.back().GetScalar() = DerefSizeExtractDataHelper(
-                addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size);
+                addr_bytes, size, objfile->GetByteOrder(), size);
             stack.back().ClearContext();
----------------
Why size and not `8`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121732/new/

https://reviews.llvm.org/D121732



More information about the lldb-commits mailing list