[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Core/Debugger.cpp:1757
+  File &output = GetOutputFile();
+  if (!output.GetIsTerminalWithColors() || !GetShowProgress())
+    return;
----------------
aprantl wrote:
> And withColors also implies that it's an interactive TTY?
Yup


================
Comment at: lldb/source/Core/Debugger.cpp:1762
+  if (data->GetCompleted()) {
+    output.Printf("\33[2K\r");
+    return;
----------------
aprantl wrote:
> I guess Colors also implies it supports \r? Sure.
> Can you comment what this escape sequence does?
The comment on line 1760 explains that this clears the current line. I can move it down to make it more obvious.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120972/new/

https://reviews.llvm.org/D120972