[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:413-416
+    if (!has_path && !has_uuid)
+      return error_with_message("Dictionary should have key 'path' or 'uuid'");
+    if (!dict->HasKey("load_addr"))
+      return error_with_message("Dictionary is missing field 'load_addr'");
----------------
Nit: you're calling it a key in the first error message, but `field` in the second. Let's pick one and be consistent. 


================
Comment at: lldb/test/API/functionalities/scripted_process/stack_core_scripted_process.py:45
+
+        lib_load_addr = 0x00000001001e0000
+        self.loaded_images.append({"path": self.lib_path,
----------------
What exactly is this value? Shouldn't we get the load address from the core file and report that? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120969/new/

https://reviews.llvm.org/D120969