[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

Awesome! I could see this getting improved in the future by stacking each progress event in the output with their completion amount and popping the ones that are completed.



================
Comment at: lldb/source/Core/Debugger.cpp:1727
+
+  // Only report progress is nobody else is listening for it.
+  if (GetBroadcaster().EventTypeHasListeners(Debugger::eBroadcastBitProgress))
----------------



================
Comment at: lldb/source/Core/Debugger.cpp:1822
+            [this] { return ProgressHandlerThread(); },
+            8 * 1024 * 1024); // Use larger 8MB stack for this thread
+    if (progress_handler_thread) {
----------------
Why ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120972/new/

https://reviews.llvm.org/D120972