[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:84
   static ConstString GetEventIdentifier();
+  static const char *
+      BreakpointEventTypeAsCString(lldb::BreakpointEventType type);
----------------
JDevlieghere wrote:
> Why not a llvm::StringRef?
This is returning a null terminated C-string.  What would be gained by passing it out as a StringRef so that clients had to call c_str on it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120917/new/

https://reviews.llvm.org/D120917