[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 3 10:29:28 PST 2022


kastiglione added inline comments.


================
Comment at: lldb/source/Utility/Broadcaster.cpp:211-215
+  Log *log = GetLog(LLDBLog::Events);
+  if (!log && event_sp->GetData())
+    log = event_sp->GetData()->GetLogChannel();
+
+  if (log) {
----------------
should this log to both channels? I find it slightly unexpected that an event wouldn't be printed to the events channel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120917/new/

https://reviews.llvm.org/D120917



More information about the lldb-commits mailing list