[Lldb-commits] [lldb] 742fb13 - Revert "[lldb] Correct case in description of breakpoint --on-catch/throw"

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2022-03-03T17:20:31Z
New Revision: 742fb134753b62f827677be92c48699d02f7f458

URL: https://github.com/llvm/llvm-project/commit/742fb134753b62f827677be92c48699d02f7f458
DIFF: https://github.com/llvm/llvm-project/commit/742fb134753b62f827677be92c48699d02f7f458.diff

LOG: Revert "[lldb] Correct case in description of breakpoint --on-catch/throw"

This reverts commit 6b3b3ef344504334f43afe76c805d2e6e7b587e9.

Jim Ingham informed me that the upper case is a hint to the option
name, like you might see in a menu to show you what the shortcut is.

Added: 
    

Modified: 
    lldb/source/Commands/Options.td
    lldb/test/API/functionalities/completion/TestCompletion.py

Removed: 
    


################################################################################
diff  --git a/lldb/source/Commands/Options.td b/lldb/source/Commands/Options.td
index 470f4bc471c3e..a1548cb6b443f 100644
--- a/lldb/source/Commands/Options.td
+++ b/lldb/source/Commands/Options.td
@@ -176,9 +176,9 @@ let Command = "breakpoint set" in {
     Desc<"Set the breakpoint on exceptions thrown by the specified language "
     "(without options, on throw but not catch.)">;
   def breakpoint_set_on_throw : Option<"on-throw", "w">, Group<10>,
-    Arg<"Boolean">, Desc<"Set the breakpoint on exception throw.">;
+    Arg<"Boolean">, Desc<"Set the breakpoint on exception throW.">;
   def breakpoint_set_on_catch : Option<"on-catch", "h">, Group<10>,
-    Arg<"Boolean">, Desc<"Set the breakpoint on exception catch.">;
+    Arg<"Boolean">, Desc<"Set the breakpoint on exception catcH.">;
   def breakpoint_set_language : Option<"language", "L">, GroupRange<3, 8>,
     Arg<"Language">,
     Desc<"Specifies the Language to use when interpreting the breakpoint's "

diff  --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index e858e38035c86..ed901890f7dfe 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -539,20 +539,20 @@ def test_completion_description_command_options(self):
         """Test descriptions of command options"""
         # Short options
         self.check_completion_with_desc("breakpoint set -", [
-            ["-h", "Set the breakpoint on exception catch."],
-            ["-w", "Set the breakpoint on exception throw."]
+            ["-h", "Set the breakpoint on exception catcH."],
+            ["-w", "Set the breakpoint on exception throW."]
         ])
 
         # Long options.
         self.check_completion_with_desc("breakpoint set --", [
-            ["--on-catch", "Set the breakpoint on exception catch."],
-            ["--on-throw", "Set the breakpoint on exception throw."]
+            ["--on-catch", "Set the breakpoint on exception catcH."],
+            ["--on-throw", "Set the breakpoint on exception throW."]
         ])
 
         # Ambiguous long options.
         self.check_completion_with_desc("breakpoint set --on-", [
-            ["--on-catch", "Set the breakpoint on exception catch."],
-            ["--on-throw", "Set the breakpoint on exception throw."]
+            ["--on-catch", "Set the breakpoint on exception catcH."],
+            ["--on-throw", "Set the breakpoint on exception throW."]
         ])
 
         # Unknown long option.