[Lldb-commits] [lldb] 6b3b3ef - [lldb] Correct case in description of breakpoint --on-catch/throw

[Jim Ingham via lldb-commits]

This was on purpose - I do it whenever the short option isn't the first letter of the long option as an aid to memorization.  Some people catch this and it helps, others correct the spelling in checkins without noticing what they are for.

I thought it was helpful, but maybe it only annoys people who see the oddity w/o noticing what it is for, in which case we should remove them wholesale rather than one by one.

Jim


> On Mar 3, 2022, at 2:06 AM, David Spickett via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> 
> Author: David Spickett
> Date: 2022-03-03T10:06:11Z
> New Revision: 6b3b3ef344504334f43afe76c805d2e6e7b587e9
> 
> URL: https://github.com/llvm/llvm-project/commit/6b3b3ef344504334f43afe76c805d2e6e7b587e9
> DIFF: https://github.com/llvm/llvm-project/commit/6b3b3ef344504334f43afe76c805d2e6e7b587e9.diff
> 
> LOG: [lldb] Correct case in description of breakpoint --on-catch/throw
> 
> Somehow we ended up with catcH/throW.
> 
> Added: 
> 
> 
> Modified: 
>    lldb/source/Commands/Options.td
>    lldb/test/API/functionalities/completion/TestCompletion.py
> 
> Removed: 
> 
> 
> 
> ################################################################################
> diff  --git a/lldb/source/Commands/Options.td b/lldb/source/Commands/Options.td
> index a1548cb6b443f..470f4bc471c3e 100644
> --- a/lldb/source/Commands/Options.td
> +++ b/lldb/source/Commands/Options.td
> @@ -176,9 +176,9 @@ let Command = "breakpoint set" in {
>     Desc<"Set the breakpoint on exceptions thrown by the specified language "
>     "(without options, on throw but not catch.)">;
>   def breakpoint_set_on_throw : Option<"on-throw", "w">, Group<10>,
> -    Arg<"Boolean">, Desc<"Set the breakpoint on exception throW.">;
> +    Arg<"Boolean">, Desc<"Set the breakpoint on exception throw.">;
>   def breakpoint_set_on_catch : Option<"on-catch", "h">, Group<10>,
> -    Arg<"Boolean">, Desc<"Set the breakpoint on exception catcH.">;
> +    Arg<"Boolean">, Desc<"Set the breakpoint on exception catch.">;
>   def breakpoint_set_language : Option<"language", "L">, GroupRange<3, 8>,
>     Arg<"Language">,
>     Desc<"Specifies the Language to use when interpreting the breakpoint's "
> 
> diff  --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
> index ed901890f7dfe..e858e38035c86 100644
> --- a/lldb/test/API/functionalities/completion/TestCompletion.py
> +++ b/lldb/test/API/functionalities/completion/TestCompletion.py
> @@ -539,20 +539,20 @@ def test_completion_description_command_options(self):
>         """Test descriptions of command options"""
>         # Short options
>         self.check_completion_with_desc("breakpoint set -", [
> -            ["-h", "Set the breakpoint on exception catcH."],
> -            ["-w", "Set the breakpoint on exception throW."]
> +            ["-h", "Set the breakpoint on exception catch."],
> +            ["-w", "Set the breakpoint on exception throw."]
>         ])
> 
>         # Long options.
>         self.check_completion_with_desc("breakpoint set --", [
> -            ["--on-catch", "Set the breakpoint on exception catcH."],
> -            ["--on-throw", "Set the breakpoint on exception throW."]
> +            ["--on-catch", "Set the breakpoint on exception catch."],
> +            ["--on-throw", "Set the breakpoint on exception throw."]
>         ])
> 
>         # Ambiguous long options.
>         self.check_completion_with_desc("breakpoint set --on-", [
> -            ["--on-catch", "Set the breakpoint on exception catcH."],
> -            ["--on-throw", "Set the breakpoint on exception throW."]
> +            ["--on-catch", "Set the breakpoint on exception catch."],
> +            ["--on-throw", "Set the breakpoint on exception throw."]
>         ])
> 
>         # Unknown long option.
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits