[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:46
 using namespace lldb_private;
+using namespace llvm::dwarf;
 
----------------
JDevlieghere wrote:
> Why not `lldb_private::dwarf`? 
I think I started out with this file and must have written that by mistake.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:19
 using namespace lldb;
+using namespace dwarf;
 
----------------
JDevlieghere wrote:
> Wouldn't it be more consistent to use `lldb_private::dwarf` everywhere? 
Yeah, I was trying to match the style of  how it was done for minidump, see `source/Plugins/Process/minidump/MinidumpParser.cpp`.

Since we need access to both namespaces but in files that did already have `using namespace lldb_private;` I just used the less verbose version.

I can see arguments for just being verbose everywhere.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:35
+using namespace dwarf;
 using namespace std;
 extern int g_verbose;
----------------
JDevlieghere wrote:
> [[ https://llvm.org/docs/CodingStandards.html#do-not-use-using-namespace-std | Oh no... ]]
Yeah I noticed that was going to put that on a list of things to do, didn't feel right mixing that in here as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120836/new/

https://reviews.llvm.org/D120836