[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:46
 using namespace lldb_private;
+using namespace llvm::dwarf;
 
----------------
Why not `lldb_private::dwarf`? 


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:19
 using namespace lldb;
+using namespace dwarf;
 
----------------
Wouldn't it be more consistent to use `lldb_private::dwarf` everywhere? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120836/new/

https://reviews.llvm.org/D120836