[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only waits for the process to stop when using "launchCommands" or "attachCommands"...

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 2 14:10:45 PST 2022


clayborg updated this revision to Diff 412539.
clayborg added a comment.

Fixes:

- use a "configuration_done_sent" boolean to track when the configurationDone packet has already been sent and stop all process events from being sent before this happens. This allows "launchCommands" and "attachCommands" to have more than one stop if desired before we sync up and make sure the process is stopped after running these commands
- fixed comments to reflect the fact that we are only synchronizing with the process if "attachCommands" or "launchCommands" are used
- use steady clock


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120755/new/

https://reviews.llvm.org/D120755

Files:
  lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
  lldb/tools/lldb-vscode/VSCode.cpp
  lldb/tools/lldb-vscode/VSCode.h
  lldb/tools/lldb-vscode/lldb-vscode.cpp
  lldb/tools/lldb-vscode/package.json

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120755.412539.patch
Type: text/x-patch
Size: 10418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220302/8e021735/attachment.bin>


More information about the lldb-commits mailing list