[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

Wed Mar 2 14:09:09 PST 2022

jingham added a comment.

In D119963#3355501 <https://reviews.llvm.org/D119963#3355501>, @zequanwu wrote:

> Address comments

This sort of thing is hard to check in the option groups w/o blowing out the number of groups you need to have.

The way to check after all the option parsing is done that the options are coherent is to have the CommandOptions implement OptionParsingFinished, check the if the all_ranges is set verbose is also set, and if it isn't return a suitable error.

Can you do this (even though I see you've checked it in already.)  Silently having some combination of options not work isn't a good thing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119963/new/

https://reviews.llvm.org/D119963