[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

[Zequan Wu via Phabricator via lldb-commits]

zequanwu added inline comments.


================
Comment at: lldb/source/Commands/Options.td:962
+    "\\x01">, GroupRange<1, 6>, Desc<"Dump valid ranges of variables (must be "
+    "used in conjunction with --verbose">;
   def target_modules_lookup_verbose : Option<"verbose", "v">,
----------------
jingham wrote:
> I missed where you return an error if somebody specifies show-variable-ranges == true w/o specifying verbose.  Did I miss that?
If `show-variable-ranges` is given but not `-v`, then `show-variable-ranges` has no effect. I don't know if there is way to make it gives an error in that case.
I tried to make `show-variable-ranges` group 7 and `verbose` GroupRange <1,7>, then `-v` and `show-variable-ranges` combination is invalid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119963/new/

https://reviews.llvm.org/D119963