[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

Thanks for cleaning up the implementation file. LGMT module removing the added `lldb_private::` which I believe we no longer need.



================
Comment at: lldb/include/lldb/Core/DataFileCache.h:164
   ///   True if the signature was successfully decoded, false otherwise.
-  bool Decode(const DataExtractor &data, lldb::offset_t *offset_ptr);
+  bool Decode(const lldb_private::DataExtractor &data,
+              lldb::offset_t *offset_ptr);
----------------
I assume the header was never a problem and you did this to match the signature in the implementation file (which no longer needs the namespace qualifier without the `using namespace llvm`), unless one of the headers included here (transitively) includes a header that has the "😱 😱 😱" top level `using namespace llvm;`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120718/new/

https://reviews.llvm.org/D120718