[Lldb-commits] [PATCH] D120792: [lldb] Fix python errors in gdbremote.py

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 2 07:51:14 PST 2022


kastiglione added inline comments.


================
Comment at: lldb/examples/python/gdbremote.py:1224-1225
+        print(json.dumps(json_tree, indent=4, separators=(',', ': ')))
+    except json.JSONDecodeError:
+        return
 
----------------
I don't know this tool, but should it print the original json (`rsp`) if there's an issue when decoding the json? Or should it print a message saying invalid json was given?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120792/new/

https://reviews.llvm.org/D120792



More information about the lldb-commits mailing list