[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

This seems like a better approach, but I'm not sure how does it actually work (see inline comment). Are you sure that we're still sending input to the process (I'm not sure how much test coverage for this do we have)?



================
Comment at: lldb/source/Target/Process.cpp:4343
+        std::lock_guard<std::mutex> guard(m_mutex);
+        if (GetIsDone())
+          break;
----------------
I'm confused. How come this does not immediately terminate due to GetIsDone (through SetIsDone(true) via SetIsRunning(true) on line 4339) returning true?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120762/new/

https://reviews.llvm.org/D120762