[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.
Herald added a project: All.

Yeah, just a couple little things in the comments.  Otherwise this looks good.



================
Comment at: lldb/include/lldb/Core/Address.h:242
+            uint32_t addr_byte_size = UINT32_MAX,
+            bool all_ranges = false) const;
 
----------------
You should document all_ranges.


================
Comment at: lldb/source/Commands/Options.td:962
+    "\\x01">, GroupRange<1, 6>, Desc<"Dump valid ranges of variables (must be "
+    "used in conjunction with --verbose">;
   def target_modules_lookup_verbose : Option<"verbose", "v">,
----------------
I missed where you return an error if somebody specifies show-variable-ranges == true w/o specifying verbose.  Did I miss that?


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:2741
   };
   llvm::Error E = loctable_up->visitAbsoluteLocationList(
       offset, llvm::object::SectionedAddress{m_loclist_addresses->cu_file_addr},
----------------
Local variables in lldb are all lower case and describe what they are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119963/new/

https://reviews.llvm.org/D119963