[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D120718#3352635 <https://reviews.llvm.org/D120718#3352635>, @shafik wrote:

> In D120718#3352450 <https://reviews.llvm.org/D120718#3352450>, @JDevlieghere wrote:
>
>> I think the better solution here is to get rid of the `using namespace llvm;` in the implementation file instead.
>
> That is a good point. I did a quick look at the file `DataFileCache.h` and none of the files it includes directly use `using namespace llvm;`.
>
> It looks like across llvm-project we have 54 headers that use `using namespace llvm;` I thought it was a lot more.

It looks like at least some of those are inside functions, which is kind of OK. But what's worse, some of those are not inside functions, which is  😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱. using directives in headers completely mangle the symbol lookups in any file which includes them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120718/new/

https://reviews.llvm.org/D120718