[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

Tue Mar 1 07:44:45 PST 2022

andrew added inline comments.

================
Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:128
+
+#ifdef NT_ARM_ADDR_MASK
+  if (m_addr_mask_is_valid)
----------------
emaste wrote:
> This `#define` is coming from our headers? We need to provide this constant within LLVM so this will be available on non-FreeBSD hosts.
My understanding is this file is used on FreeBSD as it's used when debugging a currently running process.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120485/new/

https://reviews.llvm.org/D120485