[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

Tomas Matheson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 1 05:40:25 PST 2022


tmatheson added inline comments.


================
Comment at: llvm/include/llvm/Support/WithColor.h:142
+  /// Retrieve the default color auto detection function.
+  static AutoDetectFunctionType defaultAutoDetectFunction();
+
----------------
This introduces a global constructor call into libSupport, which it should not. See https://reviews.llvm.org/rG5eb2e9aa64b7be7cd8ed7f36de19c2c9bdf1977c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120593/new/

https://reviews.llvm.org/D120593



More information about the lldb-commits mailing list