[Lldb-commits] [PATCH] D120100: [lldb] Expose eBroadcastBitProgress to the SWIG SBAPI

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D120100#3331656 <https://reviews.llvm.org/D120100#3331656>, @labath wrote:

> I'm not sure how we ended up with the .i files in the first place, but maybe a good solution to this problem would be to ditch those and generate bindings from .h files directly.
>
> It may mean that we need to put `#ifndef SWIG` around some code, but I'd say that beats maintaining two separate copies of the interface. (Also, the ifdefs are a pretty good way to document the bits of the "public" API that we do not wish to make available to scripts.)

I've considered that in the past, but with the docstrings and the inline python code for things like property definitions, I'm not sure it's worth it. I assume we could move the majority of those out of the actual header and do a textual include, but then you're still on the hook for keeping that file in sync.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120100/new/

https://reviews.llvm.org/D120100