[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

Fri Feb 18 00:54:23 PST 2022

labath added a comment.

In D119548#3330773 <https://reviews.llvm.org/D119548#3330773>, @ilya-nozhkin wrote:

> In D119548#3330226 <https://reviews.llvm.org/D119548#3330226>, @clayborg wrote:
>
>> Try out the https://reviews.llvm.org/D119797 patch and see if this fixes this issue? I have just updated it after responding to comments.
>
> Yes, it fixes this particular race. But I think, that the issue is not only with stop hooks and lldb-vscode. Some other tools can do something similar to lldb-vscode and get the same issue. So, I think, it's still worth fixing the event dispatching.

Definitely worth fixing this too.

In D119548#3329785 <https://reviews.llvm.org/D119548#3329785>, @ilya-nozhkin wrote:

> Made requested changes.
>
> I agree with @jingham that if the listener is passed via launch info then we don't need to activate it in `CreateProcess`.

Sounds good. I'm happy with this if Jim is.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119548/new/

https://reviews.llvm.org/D119548