[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D119548#3327751 <https://reviews.llvm.org/D119548#3327751>, @jingham wrote:

> I don't think CreateProcess needs a HijackListener, does it?  It doesn't generate events, it just make the connection to the server.  It is always followed by Launch or DebugProcess, which are the ones that do the real work.

`CreateProcess` is called from within `DebugProcess`, but `DebugProcess` is virtual/platform-specific. That makes `CreateProcess` a handy centralized place to do this, particularly if we're *always* going to be hijacking events for the initial creation (I'm not sure what's our attach story).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119548/new/

https://reviews.llvm.org/D119548