[Lldb-commits] [lldb] 9bde881 - [lldb] Enable TestThreadStepOut on linux

[Pavel Labath via lldb-commits]

Author: Pavel Labath
Date: 2022-02-16T11:18:13+01:00
New Revision: 9bde88182317325bb95c13190a4cf303d3ce4b54

URL: https://github.com/llvm/llvm-project/commit/9bde88182317325bb95c13190a4cf303d3ce4b54
DIFF: https://github.com/llvm/llvm-project/commit/9bde88182317325bb95c13190a4cf303d3ce4b54.diff

LOG: [lldb] Enable TestThreadStepOut on linux

After applying the same for as in TestThreadBacktraceRepeat, the test
appears to pass reliably. The skip decorator was added many years ago,
so it's not clear whether this is what caused it to hang.

Added: 
    

Modified: 
    lldb/test/API/functionalities/thread/step_out/TestThreadStepOut.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/thread/step_out/TestThreadStepOut.py b/lldb/test/API/functionalities/thread/step_out/TestThreadStepOut.py
index adce28dc3f7f6..71a7e60333907 100644
--- a/lldb/test/API/functionalities/thread/step_out/TestThreadStepOut.py
+++ b/lldb/test/API/functionalities/thread/step_out/TestThreadStepOut.py
@@ -14,11 +14,6 @@ class ThreadStepOutTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    # Test occasionally times out on the Linux build bot
-    @skipIfLinux
-    @expectedFailureAll(
-        oslist=["linux"],
-        bugnumber="llvm.org/pr23477 Test occasionally times out on the Linux build bot")
     @expectedFailureAll(
         oslist=["freebsd"],
         bugnumber="llvm.org/pr18066 inferior does not exit")
@@ -30,11 +25,6 @@ def test_step_single_thread(self):
         self.build()
         self.step_out_test(self.step_out_single_thread_with_cmd)
 
-    # Test occasionally times out on the Linux build bot
-    @skipIfLinux
-    @expectedFailureAll(
-        oslist=["linux"],
-        bugnumber="llvm.org/pr23477 Test occasionally times out on the Linux build bot")
     @expectedFailureAll(
         oslist=["freebsd"],
         bugnumber="llvm.org/pr19347 2nd thread stops at breakpoint")
@@ -47,11 +37,6 @@ def test_step_all_threads(self):
         self.build()
         self.step_out_test(self.step_out_all_threads_with_cmd)
 
-    # Test occasionally times out on the Linux build bot
-    @skipIfLinux
-    @expectedFailureAll(
-        oslist=["linux"],
-        bugnumber="llvm.org/pr23477 Test occasionally times out on the Linux build bot")
     @expectedFailureAll(
         oslist=["freebsd"],
         bugnumber="llvm.org/pr19347 2nd thread stops at breakpoint")
@@ -143,9 +128,9 @@ def step_out_test(self, step_out_func):
         if len(breakpoint_threads) == 1:
             success = thread.Suspend()
             self.assertTrue(success, "Couldn't suspend a thread")
-            bkpt_threads = lldbutil.continue_to_breakpoint(self.process,
+            breakpoint_threads = lldbutil.continue_to_breakpoint(self.process,
                                                            bkpt)
-            self.assertEqual(len(bkpt_threads), 1, "Second thread stopped")
+            self.assertEqual(len(breakpoint_threads), 2, "Second thread stopped")
             success = thread.Resume()
             self.assertTrue(success, "Couldn't resume a thread")