[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Instead of polling, would it be possible for the event handler thread to send a notification (through a condition variable, std::future, etc.), and have the main thread wait for that?

But in general, avoiding flipping the modes back and forth seems like a good idea.



================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:797
+    // We manually send a thread stopped event here since the standard launch
+    // or attach API calls will eat the stopped event. But "launchCommands"
     SendThreadStoppedEvent();
----------------
is something missing here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119797/new/

https://reviews.llvm.org/D119797