[Lldb-commits] [PATCH] D118972: Increase preallocated buffer for scanning the process objc classes

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with the nits about the comments.



================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2011
 
-  const uint32_t num_classes = 128 * 1024;
+  // The number of entries to pre-allocate room for
+  const uint32_t max_num_classes = 256 * 1024;
----------------
Nit: LLVM coding style says comments need to be proper sentences starting with a capital letter and end with a period.


================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2100-2101
                num_class_infos);
-      assert(num_class_infos <= num_classes);
+      // assert if there were more classes than we pre-allocated
+      // room for.
+      assert(num_class_infos <= max_num_classes);
----------------
Same nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118972/new/

https://reviews.llvm.org/D118972