[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

> I would have expected that lldb would strip these tags before the address makes it's way over here (I'm pretty sure it needs to do that for other uses anyway). Why is that not happening?

So far we remove non-address bits for commands that need to diff pointers, memory read the obvious example. So memory write currently does not. memory region does but we don't send the address to lldb-server in that case, so it's not quite the same situation.

I'm not wedded to doing it in lldb-server, but it does have the advantage of being at a low level to catch all the possible accesses. At the expense of more complication server side. But you're right that in a lot of cases we'd need to do it in lldb for other reasons. I will try removing non-address bits purely in lldb and see how it compares.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118794/new/

https://reviews.llvm.org/D118794