[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D118812#3291969 <https://reviews.llvm.org/D118812#3291969>, @clayborg wrote:

> Yikes sorry, I read line Symtab.cpp:311 as if it was demangling the name first and then checking _its_ length...
>
> The settings leads one to believe that we don't ever demangle names longer than X characters, but it really means "don't auto demangle when indexing the symbol table". Should we actually stop the names from ever being demangled in "Mangled::GetDemangledName()" to force us to never try and demangle these kinds of names ever? We would need to have the setting modify a static value in that Mangled class when the setting gets changed so that the Mangled::GetDemangledName() function wouldn't have to try and access the settings each time someone wanted to demangle something. Then we will still display the mangled name in stack traces, but we won't ever waste time trying to demangle these names. When they are that long, they are really not useful at all for me at least.

Yeah, I considered that but I noticed some uses of the demangled names in the language plugins and I wasn't sure if that was going to break. If we think that it never makes sense to demangle these name, I'm happy to move it into Demangled and make it so that we never demangle these.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118812/new/

https://reviews.llvm.org/D118812