[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D118812#3291937 <https://reviews.llvm.org/D118812#3291937>, @clayborg wrote:

> Can we put a limit on the length of the kinds of names we are willing to demangle in the first place? How long are some of these names _prior_ to demangling? It would be great if we could skip demangling names that are too long to begin with. That would allow us to skip trying to create the demangled name in the first place which is part of the memory problem right? Once the mangled name has been added to the ConstString pool it is already too late and we won't save any memory.

Yep, that's exactly what this patch does: it checks the length of the mangled name and skips demangling if they are too long. It only does this while building the index though, so that if we need the demangled name elsewere we'll still cache it in the string pool.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118812/new/

https://reviews.llvm.org/D118812