[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

This patch does have one side-effect that I know of, which is that if we don't keep demangled names in the symbol table, then breaking on an overload by demangled name won't work.  OTOH, that only worked if you exactly matched the demangler's output - no extra spaces, etc.   We don't have a smart matcher for overloads, so I'm not sure that requiring you to supply the mangled name instead in this case is much of a burden.

And if we want to actually have a nice way to break on overloads, it would involve parsing the incoming specification, extracting the method name and arguments, finding the method name matches and then doing some kind of fuzzy match against the arguments.  So we wouldn't need to keep all the demangled strings for that purpose either.

IMO the UE for breaking on overloads is not currently good enough that it outweighs the savings we get from not storing all the demangled names.  And if this is important to somebody's workflow, they can always get the old behavior back by reversing the setting value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118814/new/

https://reviews.llvm.org/D118814