[Lldb-commits] [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

[Stella Stamenova via lldb-commits]

I will take care of it today. The bot does have vs2019 installed and it should be picking up latest VS (and it was when I updated it), so there is an easy fix (remove 2017) and then I can investigate why it stopped picking up latest.

Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Simon Pilgrim via Phabricator <reviews at reviews.llvm.org>
Sent: Saturday, January 29, 2022 3:12:52 AM
To: llvm-dev at redking.me.uk <llvm-dev at redking.me.uk>; Reid Kleckner <rnk at google.com>; aaron.ballman at gmail.com <aaron.ballman at gmail.com>; zturner at roblox.com <zturner at roblox.com>; jh7370 at my.bristol.ac.uk <jh7370 at my.bristol.ac.uk>; llvm at meinersbur.de <llvm at meinersbur.de>; jan_svoboda at apple.com <jan_svoboda at apple.com>; greg_bedwell at sn.scee.net <greg_bedwell at sn.scee.net>; Stella Stamenova <stilis at microsoft.com>
Cc: jonas at devlieghere.com <jonas at devlieghere.com>; lldb-commits at lists.llvm.org <lldb-commits at lists.llvm.org>; h.vetinari at gmx.com <h.vetinari at gmx.com>; vitalybuka at google.com <vitalybuka at google.com>; jrheng99 at gmail.com <jrheng99 at gmail.com>; reviews.llvm.org at jfbastien.com <reviews.llvm.org at jfbastien.com>; erich.keane at intel.com <erich.keane at intel.com>; joker.eph at gmail.com <joker.eph at gmail.com>; Saleem Abdulrasool <compnerd at compnerd.org>; russell.gallop at sony.com <russell.gallop at sony.com>; cfe-commits at lists.llvm.org <cfe-commits at lists.llvm.org>; mgorny at gentoo.org <mgorny at gentoo.org>; martin at martin.st <martin at martin.st>; llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>; h.imai.833 at nitech.jp <h.imai.833 at nitech.jp>; bhuvanendra.kumarn at amd.com <bhuvanendra.kumarn at amd.com>; gandhi21299 at gmail.com <gandhi21299 at gmail.com>; yanliang.mu at intel.com <yanliang.mu at intel.com>; Liburd1994 at outlook.com <Liburd1994 at outlook.com>; serhiy.redko at gmail.com <serhiy.redko at gmail.com>; quic_sourabhs at quicinc.com <quic_sourabhs at quicinc.com>; dougpuob at gmail.com <dougpuob at gmail.com>; david.spickett at linaro.org <david.spickett at linaro.org>; mlekena at skidmore.edu <mlekena at skidmore.edu>; blitzrakete at gmail.com <blitzrakete at gmail.com>; shenhan at google.com <shenhan at google.com>; michael.hliao at gmail.com <michael.hliao at gmail.com>; bruce.mitchener at gmail.com <bruce.mitchener at gmail.com>; yuanfang.chen at sony.com <yuanfang.chen at sony.com>
Subject: [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment.

@stella.stamenova It looks like the mlir-windows buildbot is still using VS2017:

  CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message):
    Host Visual Studio version must be at least 19.20, your version is
    19.16.27045.0.

Are you able to make the fix or would you prefer I revert for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD114639%2Fnew%2F&data=04%7C01%7Cstilis%40microsoft.com%7C1299827a2cee41cb745b08d9e3184ba9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637790515814400729%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WccQ1%2B3T0IE2c%2BrjkWNmZIFZFsQaaGq6NIM8gpduOpY%3D&reserved=0

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD114639&data=04%7C01%7Cstilis%40microsoft.com%7C1299827a2cee41cb745b08d9e3184ba9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637790515814400729%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=eymjF3kMlfwwx8%2Bf0B10dxYWaW%2BYkSuvmoWCCBuR2YE%3D&reserved=0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220129/277e8fda/attachment-0001.html>